-
Notifications
You must be signed in to change notification settings - Fork 52
Fix typos, add usage example, clarify tests and contributing #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @Bano733, thanks for the contribution! Please forgive the skepticism, but I'm a bit wary of encouraging minor tweaks like this with no prior discussion, two accounts with little history, and a failure to fill out the simple template in the PR comment. It smacks of low-effort AI spam. If I'm wrong, please do set me straight, we are always happy to welcome new contributors. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #343 +/- ##
==========================================
+ Coverage 90.87% 91.75% +0.88%
==========================================
Files 31 29 -2
Lines 2400 2827 +427
==========================================
+ Hits 2181 2594 +413
- Misses 219 233 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Great! Thanks for the rapid response! We are definitely happy to accept simple PRs like this, thanks for being understanding any the red flags. Will try to get a more substantive comment to you by EOD |
|
Test failure (obviously) unrelated |
Co-authored-by: Kevin Bonham <[email protected]>
Co-authored-by: Kevin Bonham <[email protected]>
|
Thanks for the feedback! I fixed the code block formatting and added the canonical dna"ACGTACGT" example as suggested. I also removed the duplicate line in the contributing section. Let me know if you want any further adjustments. |
|
Thank you for the review and merge!
I appreciate the feedback and look forward to contributing again.
…On Thu, Dec 4, 2025, 8:29 PM Kevin Bonham ***@***.***> wrote:
Merged #343 <#343> into
master.
—
Reply to this email directly, view it on GitHub
<#343 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BQ4RRS3LOWLEK6CXYWBVSSL4ABHOBAVCNFSM6AAAAACNN462X2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRRGM3DENZZGE2TOMQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Thank you for your contribution!
If you have any questions about your PR, or need help completing it, you can ping the maintainers of this repository, who will be happy to help if they can find time.
You can optionally use the following checklist when you work on your PR: